[Webkit-unassigned] [Bug 213278] IPC/Decoder.h and IPC/Encoder.h need every WTF::EnumTraits<> specialization included before they are included

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213278

--- Comment #5 from Darin Adler <darin at apple.com> ---
(In reply to David Kilzer (:ddkilzer) from comment #4)
> Okay, using pre-processed source, I've verified that if I don't #include
> <WebCore/ContextMenuItem.h> in Decoder.h/Encoder.h, then the specialized
> isValidEnum() function is included after it's needed in Decoder.h/Encoder.h
> when building Source/WebKit/Shared/WebContextMenuItemData.cpp.

We need to look deeper into *this*. Typically you don’t need things that templates depend on until you instantiate the template, so it doesn’t make logical sense that the order of includes would matter if these things in Decoder.h and Encoder.h are templates. Before we make any changes, we need to figure out more precisely exactly what goes wrong when ContextMenuItem.h is included after the templates, but before the templates are instantiated because they are used.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200623/a8a978cf/attachment.htm>