[Webkit-unassigned] [Bug 213291] Add support for fetching registrable domains with resource load statistics

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213291

--- Comment #14 from youenn fablet <youennf at gmail.com> ---
> > > Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:1375
> > > +        postTaskReply([domains = WTFMove(domains), completionHandler = WTFMove(completionHandler)]() mutable {
> > 
> > Hopping to another thread, this requires isolatedCopying domains.
> 
> Also when moving?

Yes, moving will only prevent refing when capturing.
It is safe to hop to another thread with a String which counter is 1. But otherwise, like in the in memory case, the strings may be derefed in both threads.
There is no guarantee that this will be the case in your code (especially for in memory stores).
Also isolatedCopy tries to optimise the case of Strings that are moved and which counter is 1, see String String::isolatedCopy() &&.

We could try to optimise the case of a Vector<T>&& so as to reuse the allocated vector and call isolatedCopy() && on each item as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200618/12a30175/attachment.htm>