[Webkit-unassigned] [Bug 213291] Add support for fetching registrable domains with resource load statistics

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213291

--- Comment #13 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to youenn fablet from comment #11)
> Comment on attachment 402105 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402105&action=review
> 
> > Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:147
> > +    Vector<RegistrableDomain> allDomains() const override;
> 
> final?
> 
> > Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h:116
> > +    Vector<RegistrableDomain> allDomains() const override;
> 
> final?
> 
> > Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:1375
> > +        postTaskReply([domains = WTFMove(domains), completionHandler = WTFMove(completionHandler)]() mutable {
> 
> Hopping to another thread, this requires isolatedCopying domains.

Also when moving?

> > Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:1378
> > +    });
> 
> Can we write it with a ternary, something like:
> auto domains = m_statisticsStore ? m_statisticsStore->allDomains() : { };
> postTaskReply([domains = crossThreadCopy(WTFMove(domains)),
> completionHandler = WTFMove(completionHandler)]() mutable {
>     completionHandler(WTFMove(domains));
> });

Yes, I started with something like this but then I decided to follow what other similar methods in the file were doing.

> > Source/WebKit/NetworkProcess/NetworkProcess.cpp:1586
> > +                resourceLoadStatistics->registrableDomains([callbackAggregator = callbackAggregator.copyRef()](Vector<RegistrableDomain>&& domains) mutable {
> 
> s/Vector<RegistrableDomain>/auto

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200618/b7774ef4/attachment.htm>