[Webkit-unassigned] [Bug 213037] Stop to use ActiveDOMObject::setPendingActivity() for WebCore/Modules/fetch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213037

--- Comment #13 from Tetsuharu Ohzeki <tetsuharu.ohzeki at gmail.com> ---
(In reply to youenn fablet from comment #12)
> Comment on attachment 401722 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401722&action=review
> 
> > Source/WebCore/Modules/fetch/FetchBodyOwner.cpp:-259
> > -    setPendingActivity(*this);
> 
> We are no longer refing the FetchBodyOwner while loading the blo.
> This is a potential behavioural change if we do not have a
> JSFetchRequest/JSFetchResponse to keep the FetchBodyOwner alive.
> Looking at the call sites, this should be fine.

I confirmed that JSFetchRequest/JSFetchResponse (as derived class of JSDOMWrapper) hold FetchRequest/FetchResponse, they have FetchBodyOwner as a base class and keep alive it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200612/56ed8b91/attachment.htm>