[Webkit-unassigned] [Bug 213037] Stop to use ActiveDOMObject::setPendingActivity() for WebCore/Modules/fetch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213037

youenn fablet <youennf at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #401722|review?                     |review+
              Flags|                            |

--- Comment #12 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 401722
  --> https://bugs.webkit.org/attachment.cgi?id=401722
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401722&action=review

> Source/WebCore/Modules/fetch/FetchBodyOwner.cpp:-259
> -    setPendingActivity(*this);

We are no longer refing the FetchBodyOwner while loading the blo.
This is a potential behavioural change if we do not have a JSFetchRequest/JSFetchResponse to keep the FetchBodyOwner alive.
Looking at the call sites, this should be fine.

> Source/WebCore/Modules/fetch/FetchBodyOwner.h:106
> +    bool virtualHasPendingActivity() const override;

Could probably be final.

> Source/WebCore/Modules/fetch/FetchBodySource.cpp:53
>      if (m_bodyOwner)

No need for this if check.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200612/cf52fa1e/attachment.htm>