[Webkit-unassigned] [Bug 214550] [FreeType] Add support for text-underline-offset and text-decoration-thickness

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=214550

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Adrian Perez from comment #2)
> Comment on attachment 404711 [details]
> Patch
> 
> I'm almost tempted to r+ this, but I think the comment below is important
> enough to double check it before, so please take a look.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=404711&action=review
> 
> > Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:79
> > +    if (!determinant)
> 
> Is the intention here to check for zero exactly, or for some floating point
> value that is small enough that is logically zero? In the latter case, this
> looks like a footgun hiding in plain sight and it would be better to compare
> “std::fabs(determinant) < K” for a reasonable value of “K”, otherwise the
> value of “determinant” can be almost-but-not zero and defeat the check.

Zero exactly. See the cairo code from which I took this:

https://cgit.freedesktop.org/cairo/tree/src/cairo-matrix.c#n685

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200720/5f6b5bfe/attachment.htm>