[Webkit-unassigned] [Bug 214550] [FreeType] Add support for text-underline-offset and text-decoration-thickness

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=214550

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com

--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 404711
  --> https://bugs.webkit.org/attachment.cgi?id=404711
Patch

I'm almost tempted to r+ this, but I think the comment below is important
enough to double check it before, so please take a look.

View in context: https://bugs.webkit.org/attachment.cgi?id=404711&action=review

> Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:79
> +    if (!determinant)

Is the intention here to check for zero exactly, or for some floating point
value that is small enough that is logically zero? In the latter case, this
looks like a footgun hiding in plain sight and it would be better to compare
“std::fabs(determinant) < K” for a reasonable value of “K”, otherwise the
value of “determinant” can be almost-but-not zero and defeat the check.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200720/6e1c79f3/attachment.htm>