[Webkit-unassigned] [Bug 206794] REGRESSION(2.28): [GTK] WPE implementation of show-option-menu breaks the GTK binding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206794

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgarcia at igalia.com

--- Comment #1 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #0)
> [84/87] Generating ../../WebKit2-4.0.gir
> ../../../../../../Projects/WebKit/Source/WebKit/UIProcess/API/glib/
> WebKitWebView.cpp:2137: Warning: WebKit2: multiple comment blocks
> documenting 'WebKitWebView::show-option-menu:' identifier (already seen at
> WebKitWebView.cpp:2101).
> ../../../../../../Projects/WebKit/Source/WebKit/UIProcess/API/glib/
> WebKitWebView.cpp:2137: Warning: WebKit2: incorrect number of parameters in
> comment block, parameter annotations will be ignored.
> 
> The problem is that introspection scanner doesn't respect #if PLATFORM(WPE).

Some how it does, the gir generated is correct. The backend property is inside PLATFORM(WPE) ifdef and it's not included in the gir. The same happens in gtk-doc generated html.

> I tried adding #ifndef __GI_SCANNER__ but that didn't work. I think it's
> going to require adding a platformClassInit() call in order to split the WPE
> signal registration out into WebKitWebViewWPE.cpp. (But not for GTK, because
> that would break the introspection.) That might be acceptable if we never
> care about making the WPE API introspectable.
> 
> If we do care about WPE introspection, then I don't know what to suggest.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200129/0a92b587/attachment.htm>