[Webkit-unassigned] [Bug 206794] New: REGRESSION(2.28): [GTK] WPE implementation of show-option-menu breaks the GTK binding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206794

            Bug ID: 206794
           Summary: REGRESSION(2.28): [GTK] WPE implementation of
                    show-option-menu breaks the GTK binding
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKitGTK
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at gnome.org
                CC: bugs-noreply at webkitgtk.org

[84/87] Generating ../../WebKit2-4.0.gir
../../../../../../Projects/WebKit/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:2137: Warning: WebKit2: multiple comment blocks documenting 'WebKitWebView::show-option-menu:' identifier (already seen at WebKitWebView.cpp:2101).
../../../../../../Projects/WebKit/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:2137: Warning: WebKit2: incorrect number of parameters in comment block, parameter annotations will be ignored.

The problem is that introspection scanner doesn't respect #if PLATFORM(WPE).

I tried adding #ifndef __GI_SCANNER__ but that didn't work. I think it's going to require adding a platformClassInit() call in order to split the WPE signal registration out into WebKitWebViewWPE.cpp. (But not for GTK, because that would break the introspection.) That might be acceptable if we never care about making the WPE API introspectable.

If we do care about WPE introspection, then I don't know what to suggest.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200125/e5805e8b/attachment.htm>