[Webkit-unassigned] [Bug 206724] Nullptr crash when setting custom properties on detached style

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206724

--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 388631
  --> https://bugs.webkit.org/attachment.cgi?id=388631
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388631&action=review

>>> Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp:260
>>> +        ASSERT(document);
>> 
>> Why is this assertion safe? Since m_lastDocument is a WeakPtr, what guarantees it won’t be null?
> 
> This assert shouldn't be here, it's a leftover from debugging. setCustomProperty can handle null document, the crash was from assuming there would always be a parentStyleSheet() when there isn't a parentElement().

If parentStyleSheet is null too, then why can't we let document be null? Why do we need this m_lastDocument trick?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200128/5c1b1b56/attachment-0001.htm>