[Webkit-unassigned] [Bug 206724] Nullptr crash when setting custom properties on detached style

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206724

--- Comment #7 from Sunny He <sunny_he at apple.com> ---
Comment on attachment 388631
  --> https://bugs.webkit.org/attachment.cgi?id=388631
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388631&action=review

>> Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp:260
>> +        ASSERT(document);
> 
> Why is this assertion safe? Since m_lastDocument is a WeakPtr, what guarantees it won’t be null?

This assert shouldn't be here, it's a leftover from debugging. setCustomProperty can handle null document, the crash was from assuming there would always be a parentStyleSheet() when there isn't a parentElement().

>> LayoutTests/fast/dom/StyleSheet/detached-style-set-custom-property.html:18
>> +    <script src="../../../resources/js-test-post.js"></script>
> 
> Please use ../../../resources/js-test.js instead of js-test-pre.js, then js-test-post.js is not needed.

Thanks, will fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200128/3114fd0b/attachment-0001.htm>