[Webkit-unassigned] [Bug 206317] Clamp paddingBoxWidth/Height to a minimum of zero

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206317

--- Comment #8 from zalan <zalan at apple.com> ---
Comment on attachment 388594
  --> https://bugs.webkit.org/attachment.cgi?id=388594
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388594&action=review

> Source/WebCore/rendering/RenderReplaced.cpp:461
> -    logicalWidth = std::max(0_lu, (logicalWidth - (marginStart + marginEnd + (size().width() - clientWidth()))));
> +    logicalWidth = std::max(0_lu, (logicalWidth - (marginStart + marginEnd + borderLeft() + borderRight() + verticalScrollbarWidth())));

I am confused how this works (or even worked before). The logical width here (which is the content logical width) of an inline replaced box is supposed to be the containing block's content box width - (margin start + border inline start + padding inline start + padding inline end + border inline end + margin end), since the constraint equation is as follows containing block's content width = margin s + border s + padding s + content width + padding e + border e + margin e.
It's even in the comment a few lines above.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200124/69ce9a5f/attachment.htm>