[Webkit-unassigned] [Bug 206317] Clamp paddingBoxWidth/Height to a minimum of zero

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206317

--- Comment #7 from Sunny He <sunny_he at apple.com> ---
(In reply to Simon Fraser (smfr) from comment #5)
> Comment on attachment 388593 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388593&action=review
> 
> > Source/WebCore/rendering/RenderReplaced.cpp:464
> > +    WTFLogAlways("computeConstrainedLogicalWidth logicalWidth=%f, marginStart=%f, marginEnd=%f, size().width()=%f, clientWidth()=%f",
> > +        logicalWidth.toFloat(), marginStart.toFloat(), marginEnd.toFloat(), size().width().toFloat(), clientWidth().toFloat());
> > +    logicalWidth = std::max(0_lu, (logicalWidth - (marginStart + marginEnd + borderLeft() + borderRight() + verticalScrollbarWidth())));
> > +    WTFLogAlways("computeConstrainedLogicalWidth final logicalWidth=%f", logicalWidth.toFloat());
> 
> No logging please!

Fixed, looks like EWS is happy with this one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200124/38db80d6/attachment.htm>