[Webkit-unassigned] [Bug 205997] WebDriver: pressed virtual keys not correctly handled in action sequences

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=205997

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Dean Jackson from comment #2)
> Comment on attachment 387216 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387216&action=review
> 
> Can this be tested?

It's already tested, this fixes imported/w3c/webdriver/tests/perform_actions/key_modifiers.py::test_shift_modifier_generates_capital_letters[\ue008] and imported/w3c/webdriver/tests/perform_actions/key_modifiers.py::test_shift_modifier_generates_capital_letters[\ue050]

> > Source/WebDriver/Session.cpp:2613
> > +                            virtualKeys->pushString(virtualKey);
> 
> Where does currentState.pressedVirtualKeys get emptied?

The keys are removed when the keyup happens for them.

> > Source/WebDriver/Session.h:206
> > +        HashSet<String> pressedVirtualKeys;
> 
> Would this be better off as a Vector? Do you want the keys replayed in order?

You can get keyDown(Shift), keyDown(Control), keyUp(Shift), keyUp(Control) for example.

> > Source/WebKit/ChangeLog:8
> > +        When modifiers are present we need to translate the keys that might be affected by the modifiers.
> 
> I'm not sure how this is related.

There are actually two issues the tests, one is that the virtual key pressed is lost when any other keyup happens, and the other is that we don't translate the keyvals when modifiers are present. I need both changes to fix those tests. I can split the patch, but I think they are related enough.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200110/75e2b01b/attachment.htm>