[Webkit-unassigned] [Bug 205997] WebDriver: pressed virtual keys not correctly handled in action sequences

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=205997

Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dino at apple.com

--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 387216
  --> https://bugs.webkit.org/attachment.cgi?id=387216
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387216&action=review

Can this be tested?

> Source/WebDriver/Session.cpp:2613
> +                            virtualKeys->pushString(virtualKey);

Where does currentState.pressedVirtualKeys get emptied?

> Source/WebDriver/Session.h:206
> +        HashSet<String> pressedVirtualKeys;

Would this be better off as a Vector? Do you want the keys replayed in order?

> Source/WebKit/ChangeLog:8
> +        When modifiers are present we need to translate the keys that might be affected by the modifiers.

I'm not sure how this is related.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200109/68efaf05/attachment-0001.htm>