[Webkit-unassigned] [Bug 205913] [GTK] Editing: Allow line breaks in lists

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 8 06:18:46 PST 2020


--- Comment #3 from Milan Crha <mcrha at redhat.com> ---
(In reply to Carlos Garcia Campos from comment #2)
> I guess you mean instead of "InsertNewLine"

Oops, that's right. I wrote it off-head, my fault.

> This ChangeLog is not correctly formatted... we need to figure out why the
> script doesn't work for you.

Right. Any idea how to debug it? I tried to switch from the webkit-2.26 git branch to the master branch and it made the style checked happy, but the prepare-ChangeLog still claims that it didn't find any change.

> Could we just handle enter keys as all other custom key bindings and add
> them to the table above and just reove this special case?

Okay. It uncovered a bug in that code. When I've a NumLock on, then the 'state' variable says 0x10, which doesn't match any of the combined state and keycode values. Thus I fixed that too, by considering only Ctrl+Alt+Shift keys from the 'state'.

I reformatted whole "table", because the "InsertLineBreak" is longer than "InsertBacktab", thus it would need longer lines anyway.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200108/2bd2db60/attachment.htm>

More information about the webkit-unassigned mailing list