[Webkit-unassigned] [Bug 205913] [GTK] Editing: Allow line breaks in lists

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 8 03:50:31 PST 2020


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
                 CC|                            |cgarcia at igalia.com
 Attachment #387092|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 387092
  --> https://bugs.webkit.org/attachment.cgi?id=387092
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387092&action=review

r- because the changelog is not correct, cq won't allow this in any case.

> Source/WebKit/ChangeLog:9
> +	Treat Shift+Enter as "InsertLineBreak", instead of "InsertParagraph".

I guess you mean instead of "InsertNewLine"

> Source/WebKit/ChangeLog:10
> +

This ChangeLog is not correctly formatted... we need to figure out why the script doesn't work for you.

> Source/WebKit/UIProcess/gtk/KeyBindingTranslator.cpp:217
>      // Special-case enter keys for we want them to work regardless of modifier.

This comment is no longer accurate. Could we just handle enter keys as all other custom key bindings and add them to the table above and just reove this special case?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200108/ba07cc12/attachment.htm>

More information about the webkit-unassigned mailing list