[Webkit-unassigned] [Bug 205716] [GTK][WPE] Add API to retrieve and delete surrounding text for input methods

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=205716

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 386674
  --> https://bugs.webkit.org/attachment.cgi?id=386674
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386674&action=review

>> Source/WebKit/UIProcess/API/gtk/WebKitInputMethodContextImplGtk.cpp:32
>> +    unsigned surroundingCursorIndex;
> 
> Maybe explicitly initialize this to 0.

We don't do explicit initializations in GObject private structs because they are always zero-filled on allocation by GLib.

>> Source/WebKit/UIProcess/WebPageProxy.cpp:8213
>> +void WebPageProxy::deleteSurrounding(int offset, unsigned characterCount)
> 
> Should this be an int64_t, to match the WebPage::deleteSurrounding()?

Yes, I forgot to change this one

>> Tools/TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:45
>> +    unsigned surroundingCursorIndex;
> 
> Maybe initialize this too, if needed.

It's not needed, it's already zero-filled on allocation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200107/2ea47315/attachment.htm>