[Webkit-unassigned] [Bug 205716] [GTK][WPE] Add API to retrieve and delete surrounding text for input methods

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=205716

Zan Dobersek <zan at falconsigh.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zan at falconsigh.net
 Attachment #386674|review?                     |review+
              Flags|                            |

--- Comment #2 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 386674
  --> https://bugs.webkit.org/attachment.cgi?id=386674
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386674&action=review

> Source/WebKit/UIProcess/API/gtk/WebKitInputMethodContextImplGtk.cpp:32
> +    unsigned surroundingCursorIndex;

Maybe explicitly initialize this to 0.

> Source/WebKit/UIProcess/WebPageProxy.cpp:8213
> +void WebPageProxy::deleteSurrounding(int offset, unsigned characterCount)

Should this be an int64_t, to match the WebPage::deleteSurrounding()?

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:45
> +    unsigned surroundingCursorIndex;

Maybe initialize this too, if needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200107/9165804a/attachment.htm>