[Webkit-unassigned] [Bug 208002] [WPE] Use custom theme style for media controls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=208002

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Xabier Rodríguez Calvar from comment #2)
> Comment on attachment 391280 [details]
> Patch
> 
> Why are you not using GTK ones and just extend the CSS to include the icons?

Because the gtk one is going to die soon, so I copy-pasted them, added the icons and made some improvements.

> Another thing is that I am no CSS expert and there are probably several
> things there that can be improved (I see too many !important).

Sure, I have no idea about CSS, I copy-pasted the gtk css and followed what is there.

> Code seems solid but the other approach seems more logical to me (bonus
> points would be collapsing base and gtk CSS and JS files in just one. You
> could name it WPE, actually).

GTK doesn't use the base css file, and WPE either. In the case of JS it makes sense to have a base impl, to avoid duplicating code and other ports are using only the base one, so we can't delete it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200221/c5f48ed7/attachment.htm>