[Webkit-unassigned] [Bug 208002] [WPE] Use custom theme style for media controls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=208002

--- Comment #5 from Adrian Perez <aperez at igalia.com> ---
(In reply to Xabier Rodríguez Calvar from comment #2)
> Comment on attachment 391280 [details]
> Patch
> 
> Why are you not using GTK ones and just extend the CSS to include the icons?

The reason is that the plan is to switch GTK to also use the new theming
code which we are landing piecewise for WPE. There will be some PLATFORM(GTK)
guards for a few things like getting background/foreground/selection/etc.
colors and so on; but we would like to get rid of RenderThemeGTK at some
point (which is one of the trickiest “here be dragons” pieces of code of
the GTK port).

> Another thing is that I am no CSS expert and there are probably several
> things there that can be improved (I see too many !important).

So far its only copied with this minor to make sure things keep working
exactly the same once the GTK port starts using the same theming code as
the WPE port.

Improvements can be made later on, I'd say.

> Code seems solid but the other approach seems more logical to me (bonus
> points would be collapsing base and gtk CSS and JS files in just one. You
> could name it WPE, actually).

I think collapsing Base+Adwaita cannot be done because the PlayStation
port uses the Base ones without any additions, so we will need to keep
that split.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200220/34e09d9f/attachment.htm>