[Webkit-unassigned] [Bug 207931] [macOS] Disable RunLoop function dispatch when there is a pending rendering update

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 19 11:47:08 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=207931

--- Comment #12 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 391183
  --> https://bugs.webkit.org/attachment.cgi?id=391183
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391183&action=review

> Source/WTF/wtf/RunLoop.cpp:105
> +            if (m_isFunctionDispatchSuspended)
> +                return;

It's kind of scary to allow ourselves to get into a permanently disabled state (if someone forgets to make the balancing call to setFunctionDispatchSuspended()).

Instead of a persistent setting, can we make this a one-shot behavior that automatically clears itself and then re-schedules a wakeUp()? I believe that would be sufficient to allow any scheduled rendering update to complete in the current runloop iteration.

We could call this deferring the next runloop iteration, rather than suspending it entirely.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200219/c6039b1d/attachment-0001.htm>


More information about the webkit-unassigned mailing list