[Webkit-unassigned] [Bug 207931] [macOS] Disable RunLoop function dispatch when there is a pending rendering update

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207931

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #391158|1                           |0
        is obsolete|                            |

--- Comment #11 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 391158
  --> https://bugs.webkit.org/attachment.cgi?id=391158
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391158&action=review

> Source/WTF/wtf/RunLoop.h:187
> +    bool m_isFunctionDispatchSuspended { false };

Should this be separate from a 'has pending rendering update?

> Source/WTF/wtf/cf/RunLoopCF.cpp:67
>  RunLoop::CycleResult RunLoop::cycle(RunLoopMode mode)
>  {
> +    main().setFunctionDispatchSuspended(false);

Can this be called on any runloop? Why would, say, the scrolling thread runloop care about whether function dispatch is enabled on the main runloop?

> Source/WebCore/dom/WindowEventLoop.cpp:173
> +    if (m_hasPendingRenderingUpdate) {
> +        // FIXME: Also bail out from the task loop in EventLoop::run().
> +        threadGlobalData().threadTimers().breakFireLoopForRenderingUpdate();
> +    }
>  
> +    RunLoop::main().setFunctionDispatchSuspended(m_hasPendingRenderingUpdate);

awkward that these are different.

>> Source/WebCore/dom/WindowEventLoop.h:85
>> +    static bool m_hasPendingRenderingUpdate;
> 
> Should this be a member variable rather than a static variable?

Agreed; using the m_ prefix seems like it will lead to coding errors in future.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200219/941c76f8/attachment.htm>