[Webkit-unassigned] [Bug 151030] ASSERTION FAILED: roundedIntPoint(LayoutPoint(rendererMappedResult)) == result in WebCore::RenderGeometryMap::mapToContainer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151030

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com
 Attachment #391128|review?                     |review+
              Flags|                            |

--- Comment #17 from Darin Adler <darin at apple.com> ---
Comment on attachment 391128
  --> https://bugs.webkit.org/attachment.cgi?id=391128
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391128&action=review

Looks OK. I’m frustrated that we need the data member and can’t just check m_accumulatedOffset.mightBeSaturated(), but I assume we do need it.

> Source/WebCore/rendering/RenderGeometryMap.cpp:112
> +        ASSERT_IMPLIES(!m_accumulatedOffsetSaturated, roundedIntPoint(LayoutPoint(rendererMappedResult)) == result);

I think just adding the expression "m_accumulatedOffsetSaturated &&" to the assertion would be clearer than this use of ASSERT_IMPLIES. Maybe I’m biased, because I never heard of ASSERT_IMPLIES before today.

> Source/WebCore/rendering/RenderGeometryMap.h:134
> +    bool m_accumulatedOffsetSaturated { false };

m_accumulatedOffsetMightBeSaturated

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200219/d0ab5a00/attachment.htm>