[Webkit-unassigned] [Bug 207379] [WPE] Use custom theme style to render text fields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207379

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 390069
  --> https://bugs.webkit.org/attachment.cgi?id=390069
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390069&action=review

>> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:43
>> +static const int textFieldBorderSize = 1;
> 
> Nit: I would use “unsigned” here, as it does not make sense to allow
> negative values for a border.

It's used with negative value for .inflate(), that's why I changed it to int.

> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:128
> +    fieldRect.inflate(-borderSize);

Here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200214/524459ba/attachment-0001.htm>