[Webkit-unassigned] [Bug 207379] [WPE] Use custom theme style to render text fields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207379

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com
 Attachment #390069|review?                     |review+
              Flags|                            |

--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 390069
  --> https://bugs.webkit.org/attachment.cgi?id=390069
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390069&action=review

Patch LGTM with a small unimportant nit :]

> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:43
> +static const int textFieldBorderSize = 1;

Nit: I would use “unsigned” here, as it does not make sense to allow
negative values for a border.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200214/a7df1b02/attachment.htm>