[Webkit-unassigned] [Bug 207692] [Curl] Implement functions to use ResourceLoadStatistics.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 13 10:55:55 PST 2020


--- Comment #3 from Stephan Szabo <stephan.szabo at sony.com> ---
Comment on attachment 390635
  --> https://bugs.webkit.org/attachment.cgi?id=390635
Implement some functions for ResouceLoadStatistics.

View in context: https://bugs.webkit.org/attachment.cgi?id=390635&action=review

> Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp:59
> +    blockCookies = storedCredentialsPolicy == WebCore::StoredCredentialsPolicy::EphemeralStateless || shouldBlockCookies(request);

Looking at the usage, is there a case where we want to separate the comparison with WebCore::StoredCredentialsPolicy::EphemeralStateless and the value of shouldBlockCookies(request)?
I wonder if it'd make sense to check the credentials policy inside shouldBlockCookies to prevent the possibility of misuse if the m_storedCredentialsPolicy == WebCore::StoredCredentialsPolicy::EphemeralStateless type comparsion is always required.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200213/a32c7bcc/attachment.htm>

More information about the webkit-unassigned mailing list