[Webkit-unassigned] [Bug 207692] [Curl] Implement functions to use ResourceLoadStatistics.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207692

--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 390635
  --> https://bugs.webkit.org/attachment.cgi?id=390635
Implement some functions for ResouceLoadStatistics.

View in context: https://bugs.webkit.org/attachment.cgi?id=390635&action=review

A couple of nitpicks from me.

> Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp:60
> +    bool blockCookies = false;
> +#if ENABLE(RESOURCE_LOAD_STATISTICS)
> +    blockCookies = storedCredentialsPolicy == WebCore::StoredCredentialsPolicy::EphemeralStateless || shouldBlockCookies(request);
> +#endif

nit: Seems like an #else would be slightly better here.

> Tools/WebKitTestRunner/TestController.cpp:3115
> +    explicit GetAllStorageAccessEntriesCallbackContext(TestController& controller, CompletionHandler<void(Vector<String>&&)>&& handler)

nit: You shouldn't need `explicit` since this has two parameters.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200213/0d4f0126/attachment-0001.htm>