[Webkit-unassigned] [Bug 187984] [Curl] Use shared single thread for WebSocket connections

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 2 14:40:04 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=187984

--- Comment #15 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #10)
> Comment on attachment 389232 [details]
> Handling connections by one thread.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=389232&action=review
> 
> > Source/WebCore/platform/network/curl/CurlStreamScheduler.cpp:137
> > +void CurlStreamScheduler::stopThread()
> 
> Is stopThread called from anywhere?

Removed.

> 
> > Source/WebCore/platform/network/curl/CurlStreamScheduler.cpp:139
> > +    m_runThread = false;
> 
> Don't you need to lock m_mutex?

Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200202/323f86d8/attachment.htm>


More information about the webkit-unassigned mailing list