[Webkit-unassigned] [Bug 187984] [Curl] Use shared single thread for WebSocket connections
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Feb 2 14:50:18 PST 2020
https://bugs.webkit.org/show_bug.cgi?id=187984
--- Comment #16 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #8)
> Comment on attachment 389232 [details]
> Handling connections by one thread.
>
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=389232&action=review
>
> > Source/WebCore/platform/network/curl/CurlStreamScheduler.cpp:48
> > + m_nextStreamID = (m_nextStreamID + 1 != invalidCurlStreamID) ? m_nextStreamID + 1 : 1;
>
> You don't check m_nextStreamID is not used.
> Can you use the pointer of client instead of m_nextStreamID?
Fixed not to use in-use IDs.
As stand in comment11 we cannot substitute IDs by pointers.
>
> > Source/WebCore/platform/network/curl/CurlStreamScheduler.h:42
> > + void destory(CurlStreamID);
>
> 'create' is typically used to create the instance of the class.
> Rename createStream and destroyStream, for example.
Fixed.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200202/bbb43fc1/attachment-0001.htm>
More information about the webkit-unassigned
mailing list