[Webkit-unassigned] [Bug 219993] $(findstring iphone, $(SDKROOT)) fails when SDKROOT is not lowercase

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219993

--- Comment #4 from Darin Adler <darin at apple.com> ---
(In reply to Ryan Hostetler from comment #3)
> The default SDKROOT path lives within the Xcode directory eg:
> /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/
> Developer/SDKs/iPhoneOS13.0.sdk
> 
> The most likely problem would arise from a renamed Xcode eg:
> `Xcode-iphone.app`, which is still a risk without this patch.

Or an Xcode someone put into a directory like "/Users/darin/iPhoneTools".

And, yes, I was not suggesting it’s new in this patch, although doing case folding makes it even more likely to get it wrong.

> If we wanted to protect further we could use match against `sdks/iphone`,
> though I'm not sure if there are use cases where the SDK would be moved out
> of the `SDKs` path.

Sure, or even "platform/developer/sdks/iphone". Not sure what’s best.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201217/645ba2a8/attachment.htm>