[Webkit-unassigned] [Bug 219993] $(findstring iphone, $(SDKROOT)) fails when SDKROOT is not lowercase

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219993

--- Comment #3 from Ryan Hostetler <rhost at apple.com> ---
(In reply to Darin Adler from comment #2)
> Is there any user controlled directory name that can be in the SDKROOT path?
> What if the volume name contains the letter "iPhone", "TV", or "macOS" in
> them?

The default SDKROOT path lives within the Xcode directory eg:
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS13.0.sdk

The most likely problem would arise from a renamed Xcode eg: `Xcode-iphone.app`, which is still a risk without this patch.

If we wanted to protect further we could use match against `sdks/iphone`, though I'm not sure if there are use cases where the SDK would be moved out of the `SDKs` path.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201217/6bae1f53/attachment.htm>