[Webkit-unassigned] [Bug 219759] Enable Metal backend for ANGLE, add non-spirvX compiler path for GLSL to Metal translation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Dec 12 03:01:05 PST 2020
https://bugs.webkit.org/show_bug.cgi?id=219759
--- Comment #11 from Dean Jackson <dino at apple.com> ---
Seems like the patch is too big for the review tool. Here are some comments:
- don't include changes.diff (Ken mentioned this)
- We can probably leave the complete list of files out of the ChangeLog
- The GCC_PREPROCESSOR_DEFINITIONS should go in the .xcconfig files
- I don't think we should change ANGLE's ASSERT macro
- src/common/platform.h checks for iOS < 13, but I don't believe we support that any more in WebKit
- src/common/utilities.cpp should probably keep the clang #pragma
I'll fix some of these.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201212/79b8726f/attachment-0001.htm>
More information about the webkit-unassigned
mailing list