[Webkit-unassigned] [Bug 219024] WebDriver: add support for pen pointer events

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 9 03:49:28 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=219024

--- Comment #16 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 414798
  --> https://bugs.webkit.org/attachment.cgi?id=414798
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414798&action=review

>>> Source/WebKit/Shared/WebMouseEvent.h:73
>>> +    const String& pointerType() const { return m_pointerType; }
>> 
>> It's a little weird to me that the pointerType is a string that we pass around. Is there a reason to not use an enum?
> 
> 

I guess it's because pointerType is defined in the spec as a DOMString. The spec says it can be mouse, pen and touch, but also other devices that must be prefixed. I guess we could use an enum internally indeed, but it's probably out fo the scope of this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201209/88c84987/attachment-0001.htm>


More information about the webkit-unassigned mailing list