[Webkit-unassigned] [Bug 219024] WebDriver: add support for pen pointer events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219024

Wenson Hsieh <wenson_hsieh at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wenson_hsieh at apple.com

--- Comment #15 from Wenson Hsieh <wenson_hsieh at apple.com> ---
(In reply to Brian Burg from comment #14)
> Comment on attachment 414798 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=414798&action=review
> 
> r=me, overall the approach looks straightforward.
> 
> Unfortunately, watchOS build is still failing:
> 
> In file included from
> /Volumes/Data/worker/watchOS-7-Build-EWS/build/WebKitBuild/Release-watchos/
> DerivedSources/WebKit2/unified-sources/UnifiedSource46-mm.mm:8:
> /Volumes/Data/worker/watchOS-7-Build-EWS/build/Source/WebKit/UIProcess/ios/
> forms/WKFocusedFormControlView.mm:134:27: error: reference to 'UIEvent' is
> ambiguous
> - (BOOL)handleWheelEvent:(UIEvent *)event
>                           ^
> 
> This looks like another UnifiedSources thing, ugh. I'll try to figure out
> what the right include is.

I suspect this is happening because we're trying to import `PointerEvent.h` in these UI process-side headers, which also pulls in DOM/bindings-related stuff like WindowProxy, FrameView, Node, etc.

Instead, we should probably pull the enum types and declarations we need to reference out into a separate header, and just import that instead of `PointerEvent.h`.

> 
> > Source/WebKit/Shared/WebMouseEvent.h:73
> > +    const String& pointerType() const { return m_pointerType; }
> 
> It's a little weird to me that the pointerType is a string that we pass
> around. Is there a reason to not use an enum?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201204/8d2d2ac3/attachment-0001.htm>