[Webkit-unassigned] [Bug 219024] WebDriver: add support for pen pointer events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219024

Brian Burg <bburg at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #414798|review?                     |review+
              Flags|                            |

--- Comment #14 from Brian Burg <bburg at apple.com> ---
Comment on attachment 414798
  --> https://bugs.webkit.org/attachment.cgi?id=414798
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414798&action=review

r=me, overall the approach looks straightforward.

Unfortunately, watchOS build is still failing:

In file included from /Volumes/Data/worker/watchOS-7-Build-EWS/build/WebKitBuild/Release-watchos/DerivedSources/WebKit2/unified-sources/UnifiedSource46-mm.mm:8:
/Volumes/Data/worker/watchOS-7-Build-EWS/build/Source/WebKit/UIProcess/ios/forms/WKFocusedFormControlView.mm:134:27: error: reference to 'UIEvent' is ambiguous
- (BOOL)handleWheelEvent:(UIEvent *)event
                          ^

This looks like another UnifiedSources thing, ugh. I'll try to figure out what the right include is.

> Source/WebKit/Shared/WebMouseEvent.h:73
> +    const String& pointerType() const { return m_pointerType; }

It's a little weird to me that the pointerType is a string that we pass around. Is there a reason to not use an enum?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201204/b9dc9f18/attachment.htm>