[Webkit-unassigned] [Bug 202307] [GStreamer] Incoherent usage of environment variables USE_PLAYBIN3 and WEBKIT_GST_USE_PLAYBIN3

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=202307

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Adrian Perez <aperez at igalia.com> ---
(In reply to Adrian Perez from comment #0)
> Both environment variables are used, I believe there should be only
> one of them:
> 
>   % rg 'getenv\(".*PLAYBIN' Source
>   Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
>   230:        if (g_getenv("USE_PLAYBIN3"))

This is a variable honored by *GStreamer*, here used to warn that
playback issues may arise from setting it, because makes GStreamer
use “playbin3” whenever client code tries to instantiate “playbin”.

>   Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>   2390:    if ((isMediaSource() || url.protocolIs("mediastream") ||
> g_getenv("WEBKIT_GST_USE_PLAYBIN3")))
>   %

And here this one is used to explicitly choose the “playbin3” element
(instead of “playbin”).

I guess this is not really a bug in the end, closing (and sorry
about the noise.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190927/64fa6ae5/attachment.html>