[Webkit-unassigned] [Bug 202307] New: [GStreamer] Incoherent usage of environment variables USE_PLAYBIN3 and WEBKIT_GST_USE_PLAYBIN3

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=202307

            Bug ID: 202307
           Summary: [GStreamer] Incoherent usage of environment variables
                    USE_PLAYBIN3 and WEBKIT_GST_USE_PLAYBIN3
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aperez at igalia.com

Both environment variables are used, I believe there should be only
one of them:

  % rg 'getenv\(".*PLAYBIN' Source
  Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
  230:        if (g_getenv("USE_PLAYBIN3"))

  Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
  2390:    if ((isMediaSource() || url.protocolIs("mediastream") || g_getenv("WEBKIT_GST_USE_PLAYBIN3")))
  %

(The “rg” tool is similar to “grep”.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190927/e66ccd6f/attachment.html>