[Webkit-unassigned] [Bug 197947] [GTK] Should use light theme unless website declares support for dark themes in color-schemes property

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 26 09:59:19 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=197947

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com

--- Comment #10 from Adrian Perez <aperez at igalia.com> ---
(In reply to Adrian Perez from comment #9)
>
> [...]
> 
> If that is the way we want things to go (forcing a non-dark theme)
> there is no need to bundle it. We can use GtkSettings::theme-name
> or GTK_THEME (as outlined above) to force using Adwaita in the Web
> process as soon as it starts.

Actually, I would try and be more fine grained here: if the current
value of GtkSettings::theme-name ends in “-dark”, remove the suffix;
in any other case set it to “Adwaita”. If the theme name resulting
from removing the “-dark” suffix is not installed, GTK will default
to Adwaita anyway.

Rationaly: If I have installed themes “Arc” and “Arc-dark”, and my
settings have “Arc-dark” configured, I would rather have controls
rendered in Web pages using “Arc” than “Adwaita”.

(Yes, I am one of those people in the intersection of “subjects who
don't like Adwaita much” and “subjects who have the slight amount
of OCD to care that widgets in Web pages get rendered at least in a
somewhat coherent way with the rest of the system theme”).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190926/3f00a73f/attachment.html>


More information about the webkit-unassigned mailing list