[Webkit-unassigned] [Bug 197947] [GTK] Should use light theme unless website declares support for dark themes in color-schemes property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197947

--- Comment #9 from Adrian Perez <aperez at igalia.com> ---
(In reply to Michael Catanzaro from comment #7)
> Sadly dark themes have *never* been well-supported by WebKitGTK (as
> evidenced by many, many bugs in this bugtracker) so I strongly recommend you
> ensure it doesn't get used until this changes... somehow. If it's possible
> to change theme using environment variables (not sure), then you could run
> Epiphany with an envvar to force light theme, for instance.

The GTK_THEME environment variable works for all GTK+ applications:

  % GTK_THEME=Adwaita epiphany

It should also be possible to use the GtkSettings::theme-name property
to set a theme programatically. That being said, forcing its value for
any application that uses WebKitGTK would be to blatantly ignore the
user's settings: instead, I would only do it for the Web process, where
we do handling of the widgets *from Web pages*, so only those would be
affected, and the chrome of the applications using WebKitGTK (like
Epiphany) would still follow the user settings.

> If there's some particular commit that has made the situation worse
> recently, and you could identify it, then we could consider reverting.
> 
> (In reply to Cassidy James Blaede from comment #6)
> > Would it be unreasonable to bundle a light-only Adwaita with WebKitGTK, at
> > least in the meantime? Adwaita is a very neutral style and removing its dark
> > variant would not be difficult.
> 
> Maybe?

If that is the way we want things to go (forcing a non-dark theme)
there is no need to bundle it. We can use GtkSettings::theme-name
or GTK_THEME (as outlined above) to force using Adwaita in the Web
process as soon as it starts.

I would rather not bundle a GTK theme with WebKit which is expected
to be installed anyway — if we do, it will soon get desynced from
upstream Adwaita.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190926/55fd6e33/attachment.html>