[Webkit-unassigned] [Bug 201451] [GTK] Initial view loading is slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=201451

--- Comment #22 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Chris Dumez from comment #21)
> Comment on attachment 378184 [details]
> Rebased patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=378184&action=review
> 
> > Source/WebKit/UIProcess/WebPageProxy.h:1747
> > +        InitialProcess,
> 
> You may need to make sure the current process is the dummy one to determine
> that it is really the initial process launch.

Well, it doesn't matter here if it's a delayed process launch.

> > Source/WebKit/UIProcess/WebPageProxy.h:1749
> > +        Reload
> 
> I think this should be "Crash", reloading is not a reason for launching a
> new process unless the previous process has crashed.

Ok, makes sense, I followed the logic of WebPageProxy::launchProcessForReload

> > Source/WebKit/UIProcess/WebPageProxy.h:1752
> > +    void launchProcess(const WebCore::RegistrableDomain&, ProcessLaunchReason = ProcessLaunchReason::InitialProcess);
> 
> Please do not specify a default parameter value and force call sites to
> specify the reason.

Ok.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190917/7aa83526/attachment.html>