[Webkit-unassigned] [Bug 201451] [GTK] Initial view loading is slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=201451

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #378184|                            |commit-queue-
              Flags|                            |

--- Comment #21 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 378184
  --> https://bugs.webkit.org/attachment.cgi?id=378184
Rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378184&action=review

> Source/WebKit/UIProcess/WebPageProxy.h:1747
> +        InitialProcess,

You may need to make sure the current process is the dummy one to determine that it is really the initial process launch.

> Source/WebKit/UIProcess/WebPageProxy.h:1749
> +        Reload

I think this should be "Crash", reloading is not a reason for launching a new process unless the previous process has crashed.

> Source/WebKit/UIProcess/WebPageProxy.h:1752
> +    void launchProcess(const WebCore::RegistrableDomain&, ProcessLaunchReason = ProcessLaunchReason::InitialProcess);

Please do not specify a default parameter value and force call sites to specify the reason.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190916/a0011ffa/attachment-0001.html>