[Webkit-unassigned] [Bug 203105] VRDisplay should not prevent entering the back/forward cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203105

--- Comment #4 from Sergio Villar Senin <svillar at igalia.com> ---
(In reply to Chris Dumez from comment #3)
> (In reply to Sergio Villar Senin from comment #2)
> > Chris could you add a little bit more context?
> 
> We are working on making the back/forward cache (formerly known as the page
> cache) 100% successful at caching pages. As a result of this, we no longer
> allow ActiveDOMObjects to prevent caching. ALL ActiveDOMObject (including
> VRDisplay) need to suspend correctly.
> 
> Currently, any page which uses a VRDisplay will not be able to enter the
> back/forward cache because of this code:
> // FIXME: This should never prevent entering the back/forward cache.
> bool VRDisplay::shouldPreventEnteringBackForwardCache_DEPRECATED() const
> {
>     return true;
> }

Ah I was not aware of such a thing, it was not there when I added the code.

> This method needs to be removed to allow the page to enter the back/forward
> cache. Then you'll likely need to override ActiveDOMObject's suspend() and
> resume() to implement correct suspension. Looking at VRDisplay, it is likely
> the following needs to be done:
> 1. Instead of dispatching events synchronously, append tasks to the
> WindowEventLoop to dispatch them. The WindowEventLoop correctly suspends
> while in the cache.
> 2. Call suspend() / resume() on m_scriptedAnimationController to suspend
> animations while in the cache
> 3. Maybe call stopPresenting() on suspension? I don't know much about
> VRDisplay.

I understand the issue now, I'll come up with something.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191030/8ebd4454/attachment.htm>