[Webkit-unassigned] [Bug 203105] VRDisplay should not prevent entering the back/forward cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203105

--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
(In reply to Sergio Villar Senin from comment #4)
> (In reply to Chris Dumez from comment #3)
> > (In reply to Sergio Villar Senin from comment #2)
> > > Chris could you add a little bit more context?
> > 
> > We are working on making the back/forward cache (formerly known as the page
> > cache) 100% successful at caching pages. As a result of this, we no longer
> > allow ActiveDOMObjects to prevent caching. ALL ActiveDOMObject (including
> > VRDisplay) need to suspend correctly.
> > 
> > Currently, any page which uses a VRDisplay will not be able to enter the
> > back/forward cache because of this code:
> > // FIXME: This should never prevent entering the back/forward cache.
> > bool VRDisplay::shouldPreventEnteringBackForwardCache_DEPRECATED() const
> > {
> >     return true;
> > }
> 
> Ah I was not aware of such a thing, it was not there when I added the code.

It was there, it was just named differently. It used to be:
bool VRDisplay::canSuspendForPageCache() const
{
    return false;
}

I am pretty sure you added that code and the name is pretty clear about the implications.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191030/9cb2fd63/attachment.htm>