[Webkit-unassigned] [Bug 203408] Create base class common to AccessibilityObject and AXIsolatedTreeNode.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203408

--- Comment #2 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 381926
  --> https://bugs.webkit.org/attachment.cgi?id=381926
Created AccessibilityObjectBase, a common base class for both AccessibilityObject and AXIsolatedTreeNode.

View in context: https://bugs.webkit.org/attachment.cgi?id=381926&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:336
>      for (const auto& child : axRenderImage->children()) {

the method signature

> Source/WebCore/accessibility/AXObjectCache.cpp:2973
> +    tree->setRoot(root);

why do we want to store the actual root instead of the rootID?

> Source/WebCore/accessibility/AccessibilityTableRow.cpp:147
> +    return downcast<AccessibilityTableCell>(cell);

this downcast seems unnecessary since we're returning a AccessibilityObjectBase

> Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm:44
> +    return wrapper;

if we're detaching a wrapper I don't think we should be returning it, because it's essentially deallocated when it comes back after this method

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:121
> +    m_readerThreadNodeMap.add(root->objectID(), WTFMove(root));

I'm concerned about moving the root into the reader thread here. I think that's already supposed to have happened

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191025/469c4888/attachment-0001.htm>