[Webkit-unassigned] [Bug 203408] Create base class common to AccessibilityObject and AXIsolatedTreeNode.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203408

--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
So I think there are too many different kinds of changes rolled up in here

1) rename AXObjectInterface > AXObjectBase
2) Adopt all AXObjectBase methods in AXIsolatedTree
3) move virtual > override
4) rename matchedParent > ancestorMatch and rewrite function
   - I don't think we should add an "ax" namespace because ax isn't well known
   - we should probably have a method in WebCore namespace that's like "accessibilityAncestorMatched"
5) Lots of little cleanup for auto or -> to . syntax
6) rewrite detachWrapper
7) storing root node instead of the root node id
8) rename axObjectID -> objectID()

I'm also worried about having two AXObjectWrappers now. It will double the number of ObjC classes initialized, but I'm also concerned that there are some cases where we will reference once wrapper in once place and then another wrapper in another place and things won't work correctly.

-------

So I think we should try to break up this patch into smaller patches that separates what each patch does. It will help with reviewing and make it more clear why this change was associated with a specific bug

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191025/66f0cb1d/attachment.htm>