[Webkit-unassigned] [Bug 202980] [GTK][WPE] IconDatabase is not thread safe yet

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=202980

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Adrian Perez from comment #3)
> Comment on attachment 380970 [details]
> Patch
> 
> Patch LGTM. Given that all the uses of the database (“m_db” member)
> are done in the work queue thread, maybe it would be a good thing
> to add “ASSERT(!isMainThread())” at the top of helper functions
> like “IconDatabase::createTablesIfNeeded()” to make it clearer that
> they are not intended to be used directly from the main thread, WDYT?

Sure, I can add it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191021/62cc514c/attachment.html>