[Webkit-unassigned] [Bug 202980] [GTK][WPE] IconDatabase is not thread safe yet

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 21 01:40:50 PDT 2019


Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
                 CC|                            |aperez at igalia.com
 Attachment #380970|review?                     |review+
              Flags|                            |

--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 380970
  --> https://bugs.webkit.org/attachment.cgi?id=380970

Patch LGTM. Given that all the uses of the database (“m_db” member)
are done in the work queue thread, maybe it would be a good thing
to add “ASSERT(!isMainThread())” at the top of helper functions
like “IconDatabase::createTablesIfNeeded()” to make it clearer that
they are not intended to be used directly from the main thread, WDYT?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191021/62ab5f50/attachment.html>

More information about the webkit-unassigned mailing list