[Webkit-unassigned] [Bug 199705] Build failure in WebHTMLView.mm with the public SDK (Xcode 11 and Mojave)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199705

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #380352|0                           |1
        is obsolete|                            |

--- Comment #31 from Alexey Proskuryakov <ap at webkit.org> ---
Created attachment 380357

  --> https://bugs.webkit.org/attachment.cgi?id=380357&action=review

patch for landing

> This is confusing. The 10.15 SDK does *not* have a declaration of the
> subviews ivar. 

Indeed, thank you for catching this.

> It’s also strange to define this here, where out of context
> it’s not clear which class it’s about. Consolidating all the logic in
> NSViewSPI.h would make things more clear. The rule that the style checker is
> trying to enforce makes little sense here.

The rule is that all versions checks are in Platform.h and similar central files. There were many instances of code where engineers thought that checking versions close to use was better, but moving a subset to Platform.h proved that people were often incorrect about how well they can splatter version checks throughout the code. So now we have this rigid rule. It also helps Apple engineers think twice before doing certain weird things.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191007/9e77aeff/attachment.html>