[Webkit-unassigned] [Bug 199705] Build failure in WebHTMLView.mm with the public SDK (Xcode 11 and Mojave)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 7 13:37:54 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=199705

--- Comment #30 from mitz at webkit.org ---
Comment on attachment 380352
  --> https://bugs.webkit.org/attachment.cgi?id=380352
patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=380352&action=review

> Source/WTF/wtf/Platform.h:1627
> +#define HAVE_SUBVIEWS_IVAR_DECLARED_BY_SDK 1

This is confusing. The 10.15 SDK does *not* have a declaration of the subviews ivar. It’s also strange to define this here, where out of context it’s not clear which class it’s about. Consolidating all the logic in NSViewSPI.h would make things more clear. The rule that the style checker is trying to enforce makes little sense here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191007/b657a8b1/attachment.html>


More information about the webkit-unassigned mailing list